-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make LoopingLayoutManager open to allow customizing its behavior #72
Comments
See #70 (comment) for more context on my opinions about open-ness. But I think this is fine! So I'm going to go ahead and merge #73 =) Sorry for the late response, it's been a very busy end-of-quarter hehe. |
Looks like I need to update how I'm publishing this package! I'll dig into this more this weekend =) Thank you for filing this issue + putting up the PR! |
Thanks for the merge! |
@Maxr1998 0.5.0 has been released, which is basically just your change :P I had to update a lot of stuff to get the upload to complete successfully. So if you could check it out and tell me if it's working I would really appreciate it! Hopefully this gives you the functionality you're looking for =) Best wishes, |
@BeksOmega thanks a lot! I just tried your release and didn't notice any issue. I was already using the changes in my own release on GitHub Packages so that I could also get the fix from #69, but I nonetheless appreciate the swift response and update. Likewise, I just rebased my version on top of the latest changes. |
🔑 Use case
I'd love to be able to dynamically disable scrolling; for that, I need to override
canScrollHorizonzally()
orcanScrollVertically()
.🔨 Proposal
Add the
open
keyword to theLoopingLayoutManager
to allow extending it.🔧 Alternative
The reason I want to disable scrolling is that I'm using it as a pager, when there's just one element, scrolling should be prohibited.
📝 Other info
N/A
🐝 Request for assignment
If possible, I would like to implement this.
The text was updated successfully, but these errors were encountered: