Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LoopingLayoutManager open to allow customizing its behavior #72

Closed
Maxr1998 opened this issue Mar 23, 2023 · 5 comments · Fixed by #73
Closed

Make LoopingLayoutManager open to allow customizing its behavior #72

Maxr1998 opened this issue Mar 23, 2023 · 5 comments · Fixed by #73
Labels
bug Something isn't working

Comments

@Maxr1998
Copy link
Contributor

🔑 Use case

I'd love to be able to dynamically disable scrolling; for that, I need to override canScrollHorizonzally() or canScrollVertically().

🔨 Proposal

Add the open keyword to the LoopingLayoutManager to allow extending it.

🔧 Alternative

The reason I want to disable scrolling is that I'm using it as a pager, when there's just one element, scrolling should be prohibited.

📝 Other info

N/A

🐝 Request for assignment

If possible, I would like to implement this.

@Maxr1998 Maxr1998 added the bug Something isn't working label Mar 23, 2023
@BeksOmega
Copy link
Owner

See #70 (comment) for more context on my opinions about open-ness.

But I think this is fine! So I'm going to go ahead and merge #73 =)

Sorry for the late response, it's been a very busy end-of-quarter hehe.

@BeksOmega
Copy link
Owner

Looks like I need to update how I'm publishing this package! I'll dig into this more this weekend =) Thank you for filing this issue + putting up the PR!

@Maxr1998
Copy link
Contributor Author

Thanks for the merge!

@BeksOmega
Copy link
Owner

@Maxr1998 0.5.0 has been released, which is basically just your change :P I had to update a lot of stuff to get the upload to complete successfully. So if you could check it out and tell me if it's working I would really appreciate it!

Hopefully this gives you the functionality you're looking for =)

Best wishes,
--Beka

@Maxr1998
Copy link
Contributor Author

Maxr1998 commented Apr 2, 2023

@BeksOmega thanks a lot! I just tried your release and didn't notice any issue.

I was already using the changes in my own release on GitHub Packages so that I could also get the fix from #69, but I nonetheless appreciate the swift response and update. Likewise, I just rebased my version on top of the latest changes.

@Maxr1998 Maxr1998 closed this as completed Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants