Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search suggestions #41

Open
FireMasterK opened this issue Jan 14, 2023 · 3 comments
Open

Search suggestions #41

FireMasterK opened this issue Jan 14, 2023 · 3 comments
Labels
pinned An issue that cannot be closed automatically by Stale

Comments

@FireMasterK
Copy link

FireMasterK commented Jan 14, 2023

Out of curiosity, why don't you use the regular auto-complete API?

Like https://pipedapi.kavin.rocks/opensearch/suggestions?query=test

I'm trying to see if I can get YouTube Music's autocomplete support in Piped's API.

@Bellisario
Copy link
Owner

I wasn't using Piped autocomplete API because I needed to prevent name duplicates and get only the first 10 results.
Anyway, just found the API endpoint I was using isn't working because the API changed like you wrote above.

My old code not working anymore: https://github.com/Bellisario/musicautocomplete/blob/766093f6731a7e5aa3722b8c85400269a4ea2e7e/api.ts#L33-L44

Also, this API change seems to do exactly I need (no duplicates and 14 results I can stay on), but not supporting filter parameter which I used to search musics only: <endpoint+search>&filter=music_songs.

I think I'll start using the endpoint suggested ASAP but would be great to have a parameter to get musics only! 😉

@Bellisario
Copy link
Owner

@FireMasterK, any update?

I'm currently using the suggested endpoint (without music only filter).

@Bellisario Bellisario added the pinned An issue that cannot be closed automatically by Stale label Feb 12, 2023
@FireMasterK
Copy link
Author

Nothing yet unfortunately, we need changes in NewPipeExtractor for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned An issue that cannot be closed automatically by Stale
Projects
None yet
Development

No branches or pull requests

2 participants