Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respawn Location Bug #418

Open
tooobiiii opened this issue Feb 13, 2025 · 25 comments
Open

Respawn Location Bug #418

tooobiiii opened this issue Feb 13, 2025 · 25 comments
Assignees
Labels
cannot replicate this cannot be replicated right now under investigation this is being checked out

Comments

@tooobiiii
Copy link

Expected behavior

When the spawn location is blocked by blocks or anything else hinders the player from spawning at the location, the plugin should check again for the highest block at the OneBlock Location

Observed/Actual behavior

Currently when someone places 2 blocks on top of the OneBlock players spawn in the default world for as long as they use /ob again

Steps/models to reproduce

Create a OneBlock
Place 2 Blocks on top of it
Die
Use /ob
Die again

BentoBox version

BentoBox-3.2.3.jar
Addon -> 1.18.1

Plugin list

Image

Other

No response

@tastybento
Copy link
Member

Hmm. I can't replicate that right now. Do you have any other settings active?

Screen.Recording.2025-02-14.at.5.02.15.PM.mp4

@tastybento tastybento added the cannot replicate this cannot be replicated right now label Feb 14, 2025
@tooobiiii
Copy link
Author

I didn't really change any configs but I can send you what I am doing later when I am home

@tooobiiii
Copy link
Author

Excuse my late response i kinda forgot

@tooobiiii
Copy link
Author

@tooobiiii
Copy link
Author

also why does the spider spawn just erase surrounding blocks
https://medal.tv/games/minecraft/clips/jI3N7STU3n6HMKHkl?invite=cr-MSxuTWksMTkwMTkzNTAs

@tooobiiii
Copy link
Author

tooobiiii commented Feb 16, 2025

Also /ob phases does not tab complete without perms but op

@tooobiiii
Copy link
Author

@tastybento
Copy link
Member

Please share the output of bbox version so I can try and replicate this. I really can't understand why this would be happening and I really suspect some other plugin changing the respawn location, but let's see.

@tastybento tastybento self-assigned this Feb 17, 2025
@tastybento tastybento added the under investigation this is being checked out label Feb 17, 2025
@tastybento
Copy link
Member

Image

Is this set?

Also, share your AOneBlock and BentoBox config.yml please. (You can zip them and drop them here)

@tooobiiii
Copy link
Author

Image

island spawn is of course set. But still it sometimes makes me respawn in the default generated world.

configs.zip

@tooobiiii
Copy link
Author

Image
Also found this hologram sometimes staying.

And a bug when you are invited to an island that in /ob homes it says your name instead of the name of the island owner you were invited to.

Also /oba delete also deletes islands he is invited to instead of the the islands he is actually the owner of.

Some weird confusing things in my opinion

@tooobiiii
Copy link
Author

Also it would be cool if /oba setspawnpoint would also take in the rotation instead of only the coordinates

@tastybento
Copy link
Member

Thanks for the feedback. I'm busy during the week but I'll look at these when I can.

When mobs spawn their hitbox will clear any blocks so that they won't suffocate. Spiders have big hitboxes.

Noted on the phases tab.

I still don't know why you would spawn in the main world. It maybe that the /spawn is set there? If a safe spot cannot be found then the algorithm tries different spots and eventually tries /spawn.

@tooobiiii
Copy link
Author

Thanks for your attention to this case, i now tried disabling the default world and setting it to oneblock which worked. Now people will spawn on the spawn island at least because of worldspawnpoint but the problem with the respawn location being blocked and then players being sent to the worldspawn still persists.

So now players spawn at the world spawn when something changed at their island spawn location until they use /ob go again.

Maybe on respawn the plugin does not check if the respawn location is valid.
I would recommend to Block#getLocation().clone().toHighestLocation().add(0, 1, 0). to ensure that they will spawn even when blocks were placed / removed on the spawn location

@tooobiiii
Copy link
Author

tooobiiii commented Feb 19, 2025

Also for future recommendations / bugs, do you want me to create a new issue for every single one or can i continue listing them here when finding ones?

Here for as long as you did not respond:

Recommendations

  • [Essential] Spawn Island being editable after being set. rn you cant easily change name / flags -> Island owner being server would be nice
  • [Bug] Block#getLocation().clone().toHighestLocation().add(0, 1, 0). to ensure that they will spawn even when blocks were placed / removed on the spawn location on respawn or validate spawn location
  • [Bug] Islands that were removed using /oba delete are not erased neither available for the next user using /ob (only after restart)
  • [Essential Request] Warnings in chat for when a mob that removes surrounding blocks spawns (on first sound cue) so that players can remove / evacuate items that are nearby
  • [Bug] When being trusted on a players island it will add your names's Island in /ob homes instead of the actual islands owner. Updated when changed by owner tho
  • [Bug] /oba delete showing every island the player is trusted on instead of only his own. (Confusion for admins to delete his island)
  • [Essential] Team Members who are online and on the island wont know when the block phase ascends. Maybe show the Title to all memebers on the island or introduce a Bossbar withprogress for players on the island

@tastybento
Copy link
Member

Great! Thanks. I may break these off into separate ones if needed, but I can start work from this.

@tastybento
Copy link
Member

In regards to:

[Essential] Spawn Island being editable after being set. rn you cant easily change name / flags -> Island owner being server would be nice

When the spawn island is made, any owner is removed because it is now a spawn island. This is by design. Any editing or flag setting can be done by Op when on the island like normal though.

@tastybento
Copy link
Member

Regarding:

[Bug] Block#getLocation().clone().toHighestLocation().add(0, 1, 0). to ensure that they will spawn even when blocks were placed / removed on the spawn location on respawn or validate spawn location

There's a complex algorithm that finds a safe spot. Blocks like cobwebs are not safe of course. You start with a home location on top of the block (you can change it by sethome) but in your case it doesn't seem to find a safe spot around the block. I need to investigate more.

2 similar comments
@tastybento
Copy link
Member

Regarding:

[Bug] Block#getLocation().clone().toHighestLocation().add(0, 1, 0). to ensure that they will spawn even when blocks were placed / removed on the spawn location on respawn or validate spawn location

There's a complex algorithm that finds a safe spot. Blocks like cobwebs are not safe of course. You start with a home location on top of the block (you can change it by sethome) but in your case it doesn't seem to find a safe spot around the block. I need to investigate more.

@tastybento
Copy link
Member

Regarding:

[Bug] Block#getLocation().clone().toHighestLocation().add(0, 1, 0). to ensure that they will spawn even when blocks were placed / removed on the spawn location on respawn or validate spawn location

There's a complex algorithm that finds a safe spot. Blocks like cobwebs are not safe of course. You start with a home location on top of the block (you can change it by sethome) but in your case it doesn't seem to find a safe spot around the block. I need to investigate more.

@tastybento
Copy link
Member

In regards:

[Bug] Islands that were removed using /oba delete are not erased neither available for the next user using /ob (only after restart)

They are. Erasure is done using NMS so if you are floating by them the blocks will be locally cached on your client. If you relogin then you'll see them disappear.

Yes, island spots are not reused until the server restarts, which should be done daily for production servers. This is by design right now.

@tastybento
Copy link
Member

In regards to:

[Essential Request] Warnings in chat for when a mob that removes surrounding blocks spawns (on first sound cue) so that players can remove / evacuate items that are nearby

Okay. I'll come up with something. Only blocks should be broken.

@tastybento
Copy link
Member

Make this one separate please:

[Bug] When being trusted on a players island it will add your names's Island in /ob homes instead of the actual islands owner. Updated when changed by owner tho

Good catch.

@tastybento
Copy link
Member

This one should be separate too:

Bug] /oba delete showing every island the player is trusted on instead of only his own. (Confusion for admins to delete his island)

Thanks.

@tastybento
Copy link
Member

Good idea for this one:

[Essential] Team Members who are online and on the island wont know when the block phase ascends. Maybe show the Title to all memebers on the island or introduce a Bossbar withprogress for players on the island

I like the boss bar idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cannot replicate this cannot be replicated right now under investigation this is being checked out
Projects
None yet
Development

No branches or pull requests

2 participants