Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting itemsadder blocks #2249

Closed
2 tasks done
100petr opened this issue Dec 26, 2023 · 4 comments · Fixed by #2250
Closed
2 tasks done

Deleting itemsadder blocks #2249

100petr opened this issue Dec 26, 2023 · 4 comments · Fixed by #2250
Assignees
@tastybento
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.

Comments

@100petr
Copy link

100petr commented Dec 26, 2023

Is your feature request related to a problem?

It could be taken that way. If I build some blocks from itemsadder (https://www.spigotmc.org/resources/✨itemsadder⭐emotes-mobs-items-armors-hud-gui-emojis-blocks-wings-hats-liquids.73355/) I delete the island so the blocks are not visible, but physically still exist

Describe the solution you'd like.

I would imagine something like the one made for slimefun here #2247

Describe alternatives you've considered.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.

Other

No response
@BONNe
Copy link
Member

BONNe commented Dec 26, 2023 •
edited
Loading

I think it would be better to implement it via:
https://github.com/BONNePlayground/ItemsAdderHook

Would make more sense :)

What do you think tasty about it?

@tastybento tastybento self-assigned this Dec 27, 2023
@tastybento tastybento added the Status: Under investigation Investigating the interest and the feasability of the issue. label Dec 27, 2023
@tastybento tastybento linked a pull request Dec 27, 2023 that will close this issue
Adds an ItemAdder hook to delete any blocks when island is deleted. #2250
Merged
@tastybento
Copy link
Member

See my PR

@BONNe
Copy link
Member

BONNe commented Dec 27, 2023

I was more thinking in other way, but yeah, this works too :D

@tastybento
Copy link
Member

Okay cool.

@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tastybento tastybento

Labels
Status: Done This issue has been completed or answered. This pull request has been merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds an ItemAdder hook to delete any blocks when island is deleted. BentoBoxWorld/BentoBox
3 participants
@BONNe @tastybento @100petr