Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unscaled translation should be used with autolab_core.SimilarityTransform #5

Open
jeasinema opened this issue Jun 17, 2018 · 2 comments

Comments

@jeasinema
Copy link
Contributor

jeasinema commented Jun 17, 2018

To make it clear, the whole tranlation can be described as follows:

(1)world coordinate(unscaled)<->(2)world coordinate, but self.origin is the origin(unscaled)<->(3)sdf grid coordinate(scaled)

(3) to (2) is simply a scale transformation(multiplied by the scale factor, a.k.a. self.resolution), (2) to (1) is a translation(added by self.origin).

self.T_grid_sdf_ try to establish a tranform from (3) to (1). Since in autolab_core==0.0.4, SimilarityTransform is a two-step process begin with scale then rotation/translation(code). We should use an unscaled translation here, which means that the self.origin should not be divided by self.resolution.

@jeffmahler
Copy link
Collaborator

@jeasinema Sorry for the delay. We will look into this. Can you re-post in autolab_core? That is the source of the error.

Also please keep in mind, we are deprecating this repository in favor of trimesh.

@mmatl Can you take a quick look at this when you get a chance?

@joao-borrego
Copy link

Thank you @jeasinema !! I was generating a custom dataset for Dex-Net using custom-databases branch and I can confirm that indeed I was able to fix an issue with this transform by editing this line to t_grid_sdf = self.origin.
At least now my grasp candidates are being stored and shown correctly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants