Confirm popup #128
Open
Confirm popup #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add error check for api error * remove api error * adjust spacing in navbar * remove reset wallet state
* fix zeros and decimals * input sanitation for select field and fix crashes * disable api call for just 0 * fixed basic nits Co-authored-by: Kentaro Vadney <[email protected]> Co-authored-by: Sishir Giri <[email protected]>
* Fix bug where missing exchanges in constants file caused undefined errors and crashes
* Fix error that div tag cannot be child of paragraph tag * Fix icon and name for component.finance exchange
* Fix formatting and spinner alignment * Clear amount out when amount in is 0 * Move token dropdown components and styles to their own file * Disable scroll wheel for number input
* Move token list back to main swap form file (introduced a bug that allowed same input/output token) * Update full page spinner text and alignment * Add swap button component and handle errors with in-button messages * Add error check for inputs that are too large (causes zero division in Big Decimal library) * Add default error message
* Add general case for API errors and fix error message format * Fix key error and child of p cannot be div error
|
Someone is attempting to deploy this pull request to the OKCoin x BaB Team on Vercel. To accomplish this, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the confirmation pop up comes up, then the metamask pop up comes if the user confirms the initial pop up