Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few suggestions/bugs i have #13

Open
izmystic opened this issue Sep 5, 2023 · 19 comments
Open

A few suggestions/bugs i have #13

izmystic opened this issue Sep 5, 2023 · 19 comments

Comments

@izmystic
Copy link

izmystic commented Sep 5, 2023

  • Misc > Menu Position doesnt seem to do anything (it only applies to new menus, Recording Options, World Related Options, specific player in Online Players)
  • Misc > Display Location gives an error (@bMenu/client/menus/misc/main.lua:173: attempt to perform unsupported operation on a vector value (local 'currentPos'))
  • Vehicle > Personal Vehicle Options > Set Vehicle creates a second Current Vehicle option
  • Restarting the menu over and over will completely brick it for everyone other than the person restarting it
  • Online Players > Player > Kill doesnt work on others
  • Noclip speed doesnt live update, but will show correct speed when turned on
@BerkieBb
Copy link
Owner

BerkieBb commented Sep 5, 2023

Misc > Menu Position doesnt seem to do anything (it only applies to new menus, such as the recording one)

This is because ox_lib only applies the menu position when a menu is reopened.

@izmystic
Copy link
Author

izmystic commented Sep 5, 2023

Misc > Menu Position doesnt seem to do anything (it only applies to new menus, such as the recording one)

This is because ox_lib only applies the menu position when a menu is reopened.

even when reopening the main menu it stays in top-right

@BerkieBb
Copy link
Owner

BerkieBb commented Sep 5, 2023

Oh then it's probably because of how the menus are registered, the ones that it doesn't apply to are the ones that are static registered

@BerkieBb
Copy link
Owner

BerkieBb commented Sep 5, 2023

But with the permissions system most (or all) menus should be registered newly after everytime it should open

@izmystic
Copy link
Author

izmystic commented Sep 5, 2023

also just found that after restarting the menu a few times everyone else on the server will lose the menu entirely but the person that restarted it will still be able open it

@BerkieBb
Copy link
Owner

BerkieBb commented Sep 5, 2023

Probably a case of the MenuOpen variable not resetting properly or something with ox_lib

@izmystic
Copy link
Author

izmystic commented Sep 5, 2023

like the weather & time breaks as well when this happens

@BerkieBb
Copy link
Owner

BerkieBb commented Sep 5, 2023

Oh, so the whole code basically breaks then

@izmystic
Copy link
Author

izmystic commented Sep 5, 2023

yeah thats what it seems like

@izmystic
Copy link
Author

izmystic commented Sep 5, 2023

Killing other players doesnt work either, but it works on yourself

@BerkieBb
Copy link
Owner

BerkieBb commented Sep 5, 2023

Might be because of it being client side, this is where vMenu is outdated

@izmystic
Copy link
Author

izmystic commented Sep 5, 2023

Noclip speed doesnt live update, but will show correct speed when turned on

@BerkieBb
Copy link
Owner

BerkieBb commented Sep 5, 2023

That worked last time I tried it, or I don't remember it lol

@izmystic
Copy link
Author

izmystic commented Sep 5, 2023

let me rephrase, the text that says what speed doesnt update until turning it off and on

@BerkieBb
Copy link
Owner

BerkieBb commented Sep 5, 2023

Yeah I understood that

@BerkieBb
Copy link
Owner

I've committed 2661b72 to ensure the menu position does set on the main menu, all other menus with perms are already re-registered each time the perms are checked, so those are good already. Now I need to finish the perms to make sure other menus do set the menu position too.

@BerkieBb
Copy link
Owner

e2ca668
This should fix your Display Location error

@izmystic
Copy link
Author

going to start working on this again, is there a todo list somewhere?

@BerkieBb
Copy link
Owner

Still in client/main.lua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants