Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot propagate nested groups #12

Open
ylorant opened this issue Sep 11, 2018 · 0 comments
Open

Cannot propagate nested groups #12

ylorant opened this issue Sep 11, 2018 · 0 comments

Comments

@ylorant
Copy link
Contributor

ylorant commented Sep 11, 2018

The current version of the group transformer logic doesn't work well with how the propagator works and it causes a crash when trying to propagate a group which is nested inside a transformed group.

The propagator works propaging recursively first, which means that the most nested object gets propaged first. It does it while giving the output's object properties on the nested call to propagate nested values. The problem resides in the fact that with a transformer, you cannot know the final object structure (and thus the proprerties) once the complete object has been processed, ending in trying to access properties on something that is not generated yet.

A solution for that would be to propagate the data in the opposite order, going from the topmost object down to the nested ones, that way the parent mapped object would be there to give out to children groups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant