Modify docs of async_pre_call_hook to accept CallTypesLiteral #16302
+2
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the call_type parameter to accept any string instead of specific literals.
|
@Dobiasd is attempting to deploy a commit to the CLERKIEAI Team on Vercel. A member of the Team first needs to authorize it. |
|
|
Contributor
|
@Dobiasd i believe it should be if you want to make the update on your PR - happy to merge it in |
Contributor
Author
|
Ah, right, thanks! 👍 I just pushed the suggested fix. ✔️ |
Dobiasd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
type: 📖 Documentation
Updated the call_type parameter to accept any string instead of specific literals.
There are so many more call types than the ones that were listed, so declaring it as a
strinstead of the restricted literal will avoid surprises like the one I had when regularly receivingcall_typevalues that should not be possible according to the type annotation in the docs.