Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename maven-osgi-exec-plugin to equinox-maven-plugin #30

Open
kenwenzel opened this issue Apr 1, 2020 · 10 comments
Open

Rename maven-osgi-exec-plugin to equinox-maven-plugin #30

kenwenzel opened this issue Apr 1, 2020 · 10 comments

Comments

@kenwenzel
Copy link
Contributor

maven-osgi-exec-plugin does currently not follow Maven's naming conventions for 3rd party plugins:

Artifact Ids of the format maven-___-plugin are reserved for 
plugins in the Group Id org.apache.maven.plugins
Please change your artifactId to the format ___-maven-plugin
In the future this error will break the build.

I would suggest to simply name the plugin equinox-maven-plugin.
Later it may provide the goals configure, run (instead of exec-osgi) and test.

@kenwenzel
Copy link
Contributor Author

Maybe it is also a good idea to move this plugin into a project on its own.

@kenwenzel
Copy link
Contributor Author

Do you have any suggestions on the next step for this issue?

@tomsontom
Copy link
Member

I'd like to keep this all in one github project.

On the name what if we name it "equinox--maven-"?
We'd then have:

  • equinox-launch-maven-plugin
  • equinox-package-maven-plugin
  • equinox-targetplatform-maven-extension
  • equinox-targetplatform-maven-lib
  • equinox-targetplatform-maven-plugin

@kenwenzel
Copy link
Contributor Author

Yes, that is also ok - although the package and targetplatform plugins are more or less p2/pde specific.

@kenwenzel
Copy link
Contributor Author

Maybe equinox-launch-maven-plugin could also be named equinox-run-maven-plugin (like bnd-run-maven-plugin)...

@kenwenzel
Copy link
Contributor Author

Dear @tomsontom,
can I do anything to accelerate the refactoring?
Best regards, Ken

@tomsontom
Copy link
Member

I'm swapped with work but i'll try to reserve some time next week to work on that

@kenwenzel
Copy link
Contributor Author

@tomsontom Do you have any update for me on this task? Can I help somehow?

@tomsontom
Copy link
Member

gosh sorry - this completely fell of my list

@kenwenzel
Copy link
Contributor Author

Please let me know if I can do something :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants