Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When ActionView::Template::Error is shown, live shell is missing on last frame #466

Closed
RobinDaugherty opened this issue May 15, 2020 · 2 comments · Fixed by #477
Closed
Labels

Comments

@RobinDaugherty
Copy link
Member

RobinDaugherty commented May 15, 2020

The synthesized frame doesn't have a binding, so there's no live shell for it. There is a binding that could be used for this frame, but it's in the cause's top stack frame, not deeper in the most recent (topmost) error's stack frame.

One solution is to show the cause of the ActionView::Template::Error instead of synthesizing a backtrace frame. That would be a quick fix, but has the disadvantage that there might be useful debug information in the topmost error.

#464 would solve this while allowing the developer to navigate between the causes instead of only showing a specific one. A nice-to-have in that case would be for Better Errors to show the second cause in the chain by default, while still allowing navigation back to the ActionView::Template::Error.

@aximuseng
Copy link

Same issue here - I have a partial rendered and can't inspect anything on that page to find the nil error I am getting.

@skatkov
Copy link

skatkov commented Sep 3, 2020

We rolled back to 2.5.1 version and this bug disappeared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants