Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to evaluate 'comment' on "Getting Started REPL" #1273

Open
mcgoat96 opened this issue Aug 23, 2021 · 2 comments
Open

Fail to evaluate 'comment' on "Getting Started REPL" #1273

mcgoat96 opened this issue Aug 23, 2021 · 2 comments
Labels
documentation Better documentation needed.

Comments

@mcgoat96
Copy link

mcgoat96 commented Aug 23, 2021

Extension version:
v2.0.209

VS Code version:

Version: 1.59.1
Commit: 3866c3553be8b268c8a7f8c0482c0c0177aa8bfa
Date: 2021-08-19T11:53:52.479Z
Electron: 13.1.7
Chrome: 91.0.4472.124
Node.js: 14.16.0
V8: 9.1.269.36-electron.0
OS: Darwin x64 19.6.0

Evaluating (Option+Enter) on comment symbol (macro) itself throws

(comment "World")
|-------| <=== evaluating this span fails with trace below
; Syntax error compiling at (/var/folders/kl/<some temp path>/T/betterthantomorrow.calva/7c5x6/hello_repl.clj:0:0).
; Can't take value of a macro: #'clojure.core/comment
@PEZ
Copy link
Collaborator

PEZ commented Aug 23, 2021

Hello, happy to know you are using the Getting Started REPL!

This is actually very expected behaviour. Calva sends to the REPL whatever you ask Calva to send. And evaluating comment gives that error in the Clojure Reader. It is somewhat pointed at later on in the Clojure guide:

https://github.com/BetterThanTomorrow/dram/blob/f4266fddfcf25849e96465917c34abea078dfef3/drams/calva_getting_started/welcome_to_clojure.clj#L123

But as a beginner you don't know this of course so the guide should probably try to establish this earlier. I have filed an issue on the Dram repository, where the guides are authored: BetterThanTomorrow/dram#12

Thanks for reporting!

@mcgoat96
Copy link
Author

Hi, appreciate the speedy response and all the effort you've put into Calva!
I guess that the Dram issue will ultimately be used to resolving this one so I'm leaving it as-is instead of closing.

@bpringe bpringe added the documentation Better documentation needed. label Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Better documentation needed.
Projects
None yet
Development

No branches or pull requests

3 participants