Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise submit endpoint #60

Open
7 tasks
pbelmann opened this issue Jun 27, 2016 · 2 comments
Open
7 tasks

revise submit endpoint #60

pbelmann opened this issue Jun 27, 2016 · 2 comments

Comments

@pbelmann
Copy link
Member

pbelmann commented Jun 27, 2016

While writing tests for #36 I noticed a few possible improvements regarding the submit endpoint:

Ports

  • The container object has a list of ports objects. The mounts object contains a port object. I suggest that the container has a list of port objects. So we do not need the ports object.
  • The fields host and container should be marked as NotEmpty and NotNull

Mounts

  • The container object has a list of mounts objects. The mounts object contains a mount object. I suggest that the container has a list of mount objects. So we do not need the mounts object.

Mount

  • Modi: At the moment the rest endpoint accepts any string. We should restrict it to the allowed values (rw and ro)
  • all fields should be marked as NotNull
  • host path is allowed to be null since, a volume can be specified by using container

Additional Points:

@jkrue
Copy link
Member

jkrue commented Jun 28, 2016

I agree with everything. The nested mounts/mount ports/port object combination seems to be a result from the xjc code generation process. However as I see the necessary changes affects only the Java code but not the REST API.

I understand stdout and stderr everytime as (directory) path. Well, it may be framework dependent wether it points to an directory or file. @pbelmann, we have to discuss this

@pbelmann
Copy link
Member Author

  • All optional fields should have a method like hasContainer for container field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants