Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential problem of "InvokeId" reuse #51

Open
1 of 3 tasks
crossrw opened this issue Jan 15, 2025 · 0 comments
Open
1 of 3 tasks

Potential problem of "InvokeId" reuse #51

crossrw opened this issue Jan 15, 2025 · 0 comments

Comments

@crossrw
Copy link

crossrw commented Jan 15, 2025

Node Version: any

Node BACstack Version: 0.2.4

  • Bug Report
  • Feature Request
  • Question

Feature Request / Question

It seems to me that there is a potential issue of InvokeId reuse. It is guaranteed to occur when more than 256 BACnet devices are accessed simultaneously. At the moment, "_getInvokeId()" simply returns the next value in order, without checking its reuse.
I have no idea how to fix this yet. In my opinion, ideally there should be a queue of free "InvokeId" values. When this queue is exhausted, execution should pause waiting for free values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant