Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance issue in src/eval.py (by P3) #140

Open
DLPerf opened this issue Aug 22, 2021 · 1 comment
Open

Performance issue in src/eval.py (by P3) #140

DLPerf opened this issue Aug 22, 2021 · 1 comment

Comments

@DLPerf
Copy link

DLPerf commented Aug 22, 2021

Hello! I've found a performance issue in src/eval.py: with tf.Session(config=tf.ConfigProto(allow_soft_placement=True)) as sess:(line 52) is defined in the function eval_once(line 48) which is repeatedly called in a loop while True:(line 214).

tf.Session being defined repeatedly could lead to incremental overhead. If you define tf.Session out of the loop and pass tf.Session as a parameter to the loop, your program would be much more efficient.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

@DLPerf
Copy link
Author

DLPerf commented Nov 4, 2021

Hello, I'm looking forward to your reply~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant