Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning submissionID from avworkflow_run? #102

Closed
amstilp opened this issue May 9, 2024 · 4 comments
Closed

Returning submissionID from avworkflow_run? #102

amstilp opened this issue May 9, 2024 · 4 comments

Comments

@amstilp
Copy link

amstilp commented May 9, 2024

I've been using the Bioconductor AnVIL package to programmatically submit workflows, and it's great!

One potential improvement would be to have avworkflow_run() also return the submissionId of the job. Right now it returns the config that the workflow was submitted with. However, I can easily get that from avworkflow_configuration_inputs, but it's not so straightforward to get the submissionId. (The user has to call avworkflow_jobs() and assume that the most recent one is the submission, which is usually but not guaranteed to be true in a shared workspace.)

It does look like the Rawls API for createSubmission returns the submissionId so maybe it's not too difficult to change? I'm also open to creating a pull request to make this change, if welcomed.

@LiNk-NY
Copy link
Contributor

LiNk-NY commented May 14, 2024

Hi Adrienne, @amstilp

Thanks for creating an issue. Sorry for the delay.

The proposed solution would be to add something like LastSubmissionId to the returned config and a message such as:

Workflow submitted; Setting config$LastSubmissionId: d0069ded-9de3-43c3-8556-ceea39badb13
  See avworkflow_jobs() for more details.

How does that sound?

@LiNk-NY
Copy link
Contributor

LiNk-NY commented May 14, 2024

Feel free to test with this branch: https://github.com/Bioconductor/AnVIL/tree/workflow_run_submissionId

@amstilp
Copy link
Author

amstilp commented May 14, 2024

That sounds great, thanks for implementing!

@LiNk-NY
Copy link
Contributor

LiNk-NY commented May 14, 2024

resolved in version 1.17.2

@LiNk-NY LiNk-NY closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants