Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avworkflow_stop is 'aborting' again? #64

Closed
shbrief opened this issue Sep 27, 2022 · 2 comments
Closed

avworkflow_stop is 'aborting' again? #64

shbrief opened this issue Sep 27, 2022 · 2 comments

Comments

@shbrief
Copy link
Contributor

shbrief commented Sep 27, 2022

Hi Martin,

It seems like avworkflow_stop is 'aborting' the submissions that are successfully completed or aborted already. Can we make this function not run on submissions with the following status: 'Done', 'Aborted', and 'Aborting'?

Sehyun
mtmorgan added a commit that referenced this issue Oct 5, 2022
@mtmorgan
avoid chaning status of 'Done' workflows to 'Aborted'
b4b09ff 
- #64
@mtmorgan
Copy link
Collaborator

mtmorgan commented Oct 5, 2022

This might be tested with

BiocManager::install("Bioconductor/AnVIL", ref = "stop-running-workflows-only", force = TRUE)

@shbrief
Copy link
Contributor Author

shbrief commented Oct 6, 2022

Working as desired now - it's not changing the finalized status (i.e. Done and Aborted) anymore. Thanks!!

mtmorgan added a commit that referenced this issue Oct 6, 2022
@mtmorgan
avoid chaning status of 'Done' workflows to 'Aborted'
11962a3 
- #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtmorgan @shbrief