Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add try-except propagation status fails #308

Merged
merged 4 commits into from
Jun 23, 2023
Merged

Add try-except propagation status fails #308

merged 4 commits into from
Jun 23, 2023

Conversation

jwokaty
Copy link
Collaborator

@jwokaty jwokaty commented Jun 15, 2023 •
edited
Loading

I tested on jetstream by removing some files in public_html/3.17/bioc/nebbiolo1/buildsrc and the end of run file. It sends a message to maintainers from [email protected] with the subject "[BBS] PostRun Failed" and the following content:

    Postrun failed on the BBS with the following error:
    Error: Command '/home/biocbuild/bbs-3.17-bioc/R/bin/Rscript -e "source('/home/biocbuild/BBS/utils/makePropagationStatusDb.R');makePropagationStatusDb('OUTGOING','file://home/biocpush/PACKAGES/3.17/bioc',db_filepath='PROPAGATION_STATUS_DB.txt')"' returned non-zero exit status 1.

Would it be possible to split this from the other scenario because this could be useful as the other might take a little time to understand?

Close #297

@hpages
Copy link
Contributor

hpages commented Jun 15, 2023

Nice!

Why not send from the same address than the other emails sent by BBS? ([email protected])

Also maybe make the subject line more informative so we know immediately where to go for the troubleshooting e.g. something like "postrun failed on nebbiolo1 for the 3.17 bioc builds". Replace "nebbiolo1" with BBSvars.node_hostname, "3.17" with BBSvars.bioc_version, and "bioc" with BBSvars.buildtype.

Thanks

@jwokaty
Copy link
Collaborator Author

jwokaty commented Jun 15, 2023

@hpages Thanks, those are good ideas.

@hpages
Copy link
Contributor

hpages commented Jun 15, 2023

Small detail: the low-level bbs.* modules are usually imported before the higher-level BBS* modules. See BBS-notify.py for example.

@hpages
Copy link
Contributor

hpages commented Jun 21, 2023

Can we make sure the name of the machine shows up in the subject? Thanks

@jwokaty
Copy link
Collaborator Author

jwokaty commented Jun 23, 2023 •
edited
Loading

Sorry, I thought I had pushed this change while ago but I realized I had only pushed to my repository.

@hpages
Copy link
Contributor

hpages commented Jun 23, 2023

👍 ready to go

@jwokaty jwokaty mentioned this pull request Jun 23, 2023
Closed
@jwokaty jwokaty merged commit b9ce223 into devel Jun 23, 2023
@jwokaty jwokaty deleted the issue/297 branch June 23, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send notification to core team if postrun.sh fails
2 participants
@jwokaty @hpages