Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poem #3618

Open
10 tasks done
RoseYuan opened this issue Oct 21, 2024 · 11 comments
Open
10 tasks done

poem #3618

RoseYuan opened this issue Oct 21, 2024 · 11 comments
Labels
OK pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean

Comments

@RoseYuan
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @RoseYuan

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: poem
Title: POpulation-based Evaluation Metrics
Version: 0.99.1
Authors@R: c(
    person("Siyuan", "Luo", email="[email protected]", role=c("cre","aut"), comment=c(ORCID="0009-0007-6404-3244")),
    person("Pierre-Luc", "Germain", email="[email protected]", role=c("aut","ctb"),
 comment=c(ORCID="0000-0003-3418-4218")))
Description: Implements a set of (mostly external) evaluation metrics for comparing partitions, 
  fuzzy partitions, for evaluating the segregation of classes/clusters in embeddings or graphs, etc.
  Also includes metrics for comparing spatial data to ground truth labels and spatially visualizing 
  errors.
BugReports: https://github.com/RoseYuan/poem/issues
License: GPL (>= 3)
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.2
Depends:
    R (>= 4.0)
Imports:
    aricode,
    BiocNeighbors,
    BiocParallel,
    bluster,
    clevr,
    clue,
    cluster,
    elsa,
    fclust,
    igraph,
    Matrix,
    mclustcomp,
    methods,
    sp,
    spdep,
    stats,
    utils
Suggests: 
    testthat (>= 3.0.0),
    BiocStyle,
    knitr,
    DT,
    dplyr,
    scico,
    cowplot,
    ggnetwork,
    ggplot2,
    tidyr
VignetteBuilder: knitr
biocViews: DimensionReduction, Clustering, GraphAndNetwork, Spatial
Config/testthat/edition: 3

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Oct 21, 2024
@lshep lshep added the Post Release Deadline package submitted after posted deadline. reviewer will only review if time allows label Oct 25, 2024
@lshep lshep removed the Post Release Deadline package submitted after posted deadline. reviewer will only review if time allows label Nov 8, 2024
@lshep
Copy link
Contributor

lshep commented Nov 14, 2024

Bioconductor would like a clean repository on our system. Please remove pkgdown and Dockerfiles from default branch until after it has been cloned onto out system.

Is there a way to include a Bioconductor specific example in the vignette to show how this would work practically into a workflow and show interoperability with a common Bioconductor object/analysis? Perhaps with a SpatialExperiment object

@lshep lshep added 3e. pending pre-review changes review has indicated blocking concern that needs attention 3d. needs interop Package must explicitly use Bioconductor structures and methods labels Nov 14, 2024
@plger
Copy link

plger commented Dec 3, 2024

Hi @lshep ,
I'm just curious about your comment that "Bioconductor would like a clean repository on our system." Does that mean you want it clean only for the submission?
I (like a lot of people I suppose) keep github and Bioc in sync for all my packages to facilitate maintenance, so that even if it was "clean" upon submission it's not anymore after it's been included. Is this considered an issue or not?
Thanks in advance,
Pierre-Luc

@lshep
Copy link
Contributor

lshep commented Dec 3, 2024

Meaning the version we have on git.bioconductor.org should not contain developmental extras. After submission you could still keep a separate branch that removes those items and restore a default branch (ie. a branch called devel that is in sync with bioconductor and everything on a main branch less those features)

@RoseYuan
Copy link
Author

RoseYuan commented Dec 3, 2024

Hi @lshep,
We now have a clean devel branch as required, and we added a new vignette for our package titled "Working with SpatialExperiment" to show the interoperability with Bioconductor. Please let us know if you have further comments. Thanks.
Best regards,
Siyuan

@lshep lshep added pre-check passed pre-review performed and ready to be added to git and removed 3e. pending pre-review changes review has indicated blocking concern that needs attention 3d. needs interop Package must explicitly use Bioconductor structures and methods labels Dec 4, 2024
@bioc-issue-bot
Copy link
Collaborator

Your package has been added to git.bioconductor.org to continue the
pre-review process. A build report will be posted shortly. Please
fix any ERROR and WARNING in the build report before a reviewer is
assigned or provide a justification on why you feel the ERROR or
WARNING should be granted an exception.

IMPORTANT: Please read this documentation for setting
up remotes to push to git.bioconductor.org. All changes should be
pushed to git.bioconductor.org moving forward. It is required to push a
version bump to git.bioconductor.org to trigger a new build report.

Bioconductor utilized your github ssh-keys for git.bioconductor.org
access. To manage keys and future access you may want to active your
Bioconductor Git Credentials Account

@bioc-issue-bot bioc-issue-bot added pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean and removed 1. awaiting moderation submitted and waiting clearance to access resources pre-check passed pre-review performed and ready to be added to git labels Dec 4, 2024
@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 24.04.1 LTS): poem_0.99.2.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/poem to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: 39b4332db7e6ebcbb53b7ebd584489dd6b1a3966

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

On one or more platforms, the build results were: "ERROR".
This may mean there is a problem with the package that you need to fix.
Or it may mean that there is a problem with the build system itself.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 24.04.1 LTS): poem_0.99.3.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/poem to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot
Copy link
Collaborator

Received a valid push on git.bioconductor.org; starting a build for commit id: 692f5a30a4a8c4229b66fe0ed7f3a1521f98e564

@bioc-issue-bot
Copy link
Collaborator

Dear Package contributor,

This is the automated single package builder at bioconductor.org.

Your package has been built on the Bioconductor Single Package Builder.

Congratulations! The package built without errors or warnings
on all platforms.

Please see the build report for more details.

The following are build products from R CMD build on the Single Package Builder:
Linux (Ubuntu 24.04.1 LTS): poem_0.99.4.tar.gz

Links above active for 21 days.

Remember: if you submitted your package after July 7th, 2020,
when making changes to your repository push to
[email protected]:packages/poem to trigger a new build.
A quick tutorial for setting up remotes and pushing to upstream can be found here.

@bioc-issue-bot bioc-issue-bot added OK and removed ERROR labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OK pre-review on bioconductor git and access to on demand build but not assigned reviewer until build report clean
Projects
None yet
Development

No branches or pull requests

4 participants