Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site2Target #3666

Open
9 of 10 tasks
peymanzarrineh opened this issue Nov 28, 2024 · 6 comments
Open
9 of 10 tasks

Site2Target #3666

peymanzarrineh opened this issue Nov 28, 2024 · 6 comments
Labels
1. awaiting moderation submitted and waiting clearance to access resources

Comments

@peymanzarrineh
Copy link

Update the following URL to point to the GitHub repository of
the package you wish to submit to Bioconductor

Confirm the following by editing each check box to '[x]'

  • I understand that by submitting my package to Bioconductor,
    the package source and all review commentary are visible to the
    general public.

  • I have read the Bioconductor Package Submission
    instructions. My package is consistent with the Bioconductor
    Package Guidelines.

  • I understand Bioconductor Package Naming Policy and acknowledge
    Bioconductor may retain use of package name.

  • I understand that a minimum requirement for package acceptance
    is to pass R CMD check and R CMD BiocCheck with no ERROR or WARNINGS.
    Passing these checks does not result in automatic acceptance. The
    package will then undergo a formal review and recommendations for
    acceptance regarding other Bioconductor standards will be addressed.

  • My package addresses statistical or bioinformatic issues related
    to the analysis and comprehension of high throughput genomic data.

  • I am committed to the long-term maintenance of my package. This
    includes monitoring the support site for issues that users may
    have, subscribing to the bioc-devel mailing list to stay aware
    of developments in the Bioconductor community, responding promptly
    to requests for updates from the Core team in response to changes in
    R or underlying software.

  • I am familiar with the Bioconductor code of conduct and
    agree to abide by it.

I am familiar with the essential aspects of Bioconductor software
management, including:

  • The 'devel' branch for new packages and features.
  • The stable 'release' branch, made available every six
    months, for bug fixes.
  • Bioconductor version control using Git
    (optionally via GitHub).

For questions/help about the submission process, including questions about
the output of the automatic reports generated by the SPB (Single Package
Builder), please use the #package-submission channel of our Community Slack.
Follow the link on the home page of the Bioconductor website to sign up.

@bioc-issue-bot
Copy link
Collaborator

Hi @peymanzarrineh

Thanks for submitting your package. We are taking a quick
look at it and you will hear back from us soon.

The DESCRIPTION file for this package is:

Package: Site2Target
Type: Package
Title: An R package to associate peaks and target genes
Version: 0.99.0
Authors@R: person("Peyman Zarrineh", email="[email protected]", role=c("cre", "aut"), comment = c(ORCID = "0000-0003-4820-4101"))
Description: Statistics implemented for both peak-wise and gene-wise associations. In peak-wise associations, the p-value of the target genes of a given set of peaks are calculated. Negative binomial or Poisson distributions can be used for modeling the unweighted peaks targets and log-nromal can be used to model the weighted peaks. In gene-wise associations a table consisting of a set of genes, mapped to specific peaks, is generated using the given rules.
BugReports: https://github.com/fls-bioinformatics-core/Site2Target/issues
License: GPL-2
Encoding: UTF-8
LazyData: false
Imports: S4Vectors, stats, utils, BiocGenerics, GenomeInfoDb, MASS, IRanges, GenomicRanges
biocViews: Annotation, ChIPSeq, Software, Epigenetics, GeneExpression, GeneTarget
RoxygenNote: 7.3.2
Suggests: BiocStyle, knitr, rmarkdown
VignetteBuilder: knitr

@bioc-issue-bot bioc-issue-bot added the 1. awaiting moderation submitted and waiting clearance to access resources label Nov 28, 2024
@lshep
Copy link
Contributor

lshep commented Dec 10, 2024

When i try to R CMD build your package I'm getting the following ERROR

R CMD build Site2Target 
* checking for file 'Site2Target/DESCRIPTION' ... OK
* preparing 'Site2Target':
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
* creating vignettes ... ERROR
--- re-building ‘Site2Target.Rmd’ using rmarkdown
Could not find bibliography file: /Site2Target.bib
Error running filter /usr/bin/pandoc-citeproc:
Filter returned error status 1
Error: processing vignette 'Site2Target.Rmd' failed with diagnostics:
pandoc document conversion failed with error 83
--- failed re-building ‘Site2Target.Rmd’

SUMMARY: processing the following file failed:
  ‘Site2Target.Rmd’

Error: Vignette re-building failed.
Execution halted

@peymanzarrineh
Copy link
Author

Hello,

I got this error but I assumed it is about pandoc versioning. I could make .html file without any problem from .Rmd file. Do you know what is the problem?

Thank you,

@lshep
Copy link
Contributor

lshep commented Dec 10, 2024

I think you can just do bibliography: Site2Target.bib instead of bibliography: "`r file.path(system.file('vignettes', package = 'Site2Target'), 'Site2Target.bib')`". If that does not work I would ask on the [email protected]

@peymanzarrineh
Copy link
Author

Thank you very much! that solved the problem. Now I don't get error or warning in check and BiocCheck. now my problem is that I cannot push a new version to the Bioconductor. I do:

git remote add origin https://github.com/fls-bioinformatics-core/Site2Target.git
git remote add upstream [email protected]:packages/Site2Target.git
git remote -v
git fetch --all

"error: Could not fetch upstream"

It seems " [email protected]:packages/Site2Target" does not exists. Should I make a new issue and start from beginning?

@lshep
Copy link
Contributor

lshep commented Dec 11, 2024

it is not yet on bioconductor. this is still in the preview stage. I will check your github repo for the updates soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. awaiting moderation submitted and waiting clearance to access resources
Projects
None yet
Development

No branches or pull requests

3 participants