Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update the contents in Bioconductor Workflows section #2

Open
mckf111 opened this issue Nov 16, 2017 · 1 comment
Open

Please update the contents in Bioconductor Workflows section #2

mckf111 opened this issue Nov 16, 2017 · 1 comment

Comments

@mckf111
Copy link

mckf111 commented Nov 16, 2017

Hi,

I found the example code in the website is sometimes tricky to run (e.g. the code in Visualizing multiple genomic alteration events section, see below), what's more, in the beginning, the workflowInstall can't work, I think it is something related with the bioconductor version.

...
mut <- mut[mut$Hugo_Symbol %in% Glioma_signaling_genes,]
clinical <- plyr::rbind.fill(gbm_clin,lgg_clin)
...

I found nowhere that the authors declared the 2 variables: gbm_clin, lgg_clin. And there are several more...alas...

So please try to invest a little more time to fix those seeming tiny problems that could really block the workflow from time to time. I think that is a good way to prove to the other researchers this is a truly valuable and applicable workflow.

Sincerely,

Wenhu

@tiagochst
Copy link
Collaborator

Hello,

I'll try to update the workflow. Now some packages like ELMER and maftools will need . updates in the code for sure.

gbm_clin and lgg_clin are created in the chunk starting at line 453:

8048367#diff-2681358fc0c52be9a5a12f5e2ede5311L453

Best regards,
Tiago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants