Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing model text files #190

Open
4 tasks
CharlieOuthwaite opened this issue Jan 17, 2020 · 0 comments
Open
4 tasks

Missing model text files #190

CharlieOuthwaite opened this issue Jan 17, 2020 · 0 comments

Comments

@CharlieOuthwaite
Copy link
Contributor

In the sparta/inst/models folder, there are currently models that should not be available and a number of models files that are missing.

Any model with 'intercept' or 'centering' should not be available - these options were explored but not taken forward.

Model options missing are models that were tested within the Outhwaite et al data and simulations paper. The versions I think are missing are:

SPARTA_ranwalk (the original hyperpriors)
SPARTA_ranwalk_inversegamma
SPARTA_indran
SPARTA_ indran inversegamma
SPARTA
indran _ranwallk

These were all available at some point but don't seem to be there now. This issue has arisen through an outside user of sparta trying to run models tested in that paper and getting errors when trying to run these with either the sparta example data or their own data. The error given is something like: model file not available.

I think a few things need to be done:

  • remove model files that include centering/intercept

  • remove reference to the above from sparta documentation

  • add back in the model files that are needed to complete the model set tested in Outhwaite et al 2018.

  • Check that these model combinations work alongside the cat/cont list length options and the juldate option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants