Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Downloads from Metrics when there are no Downloadable galleys? #4299

Open
StephDriver opened this issue Jun 26, 2024 · 1 comment
Open

Comments

@StephDriver
Copy link
Contributor

Question arising from working on #3911 which involved tidying up the empty Download lists when there were no galleys avaliable for download.

When an article has no downloadable Galleys, should the download metric be hidden from view?

Reasoning - having a metric with a zero just looks bad. And depending on screenwidth, it may not be onscreen at the same time as the 'there are no downloads' statement that now appears when there are none available.

Consideration - when an article used to be downloadable, but now isn't, i.e. has a non-zero metric for downloads, then it probably should continue to show that metric.

Proposed solution: have logic if galleys and if article.metrics.downloads i.e. downloads avaliable and non-zero for past downloads.

@ajrbyers
Copy link
Member

Question arising from working on #3911 which involved tidying up the empty Download lists when there were no galleys avaliable for download.

When an article has no downloadable Galleys, should the download metric be hidden from view?

Reasoning - having a metric with a zero just looks bad. And depending on screenwidth, it may not be onscreen at the same time as the 'there are no downloads' statement that now appears when there are none available.

Consideration - when an article used to be downloadable, but now isn't, i.e. has a non-zero metric for downloads, then it probably should continue to show that metric.

Proposed solution: have logic if galleys and if article.metrics.downloads i.e. downloads avaliable and non-zero for past downloads.

This sounds like a good approach to me. The Views box should then also span the full width so its centered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants