Skip to content

Commit 3d1a38e

Browse files
committed
fix: narrow down Dockerfile drift detection
TICKET: VL-3710
1 parent 2f02521 commit 3d1a38e

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

.github/workflows/ci.yml

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -300,38 +300,38 @@ jobs:
300300
id: docker-test
301301
run: |
302302
echo "Testing Docker image bitgo/express:${{ github.sha }}"
303-
303+
304304
CONTAINER_ID=$(docker run -d -p 3080:3080 bitgo/express:${{ github.sha }})
305305
echo "Started container: $CONTAINER_ID"
306-
306+
307307
# Wait for the service to be ready with timeout
308308
echo "Waiting for service to be ready..."
309-
309+
310310
for i in {1..30}; do
311311
if curl -f -s --max-time 5 http://localhost:3080/api/v2/ping > /dev/null 2>&1; then
312312
echo "✅ API health check passed"
313313
break
314314
fi
315-
315+
316316
if [ $i -eq 30 ]; then
317317
echo "::error::API health check failed after 30 attempts"
318318
docker logs "$CONTAINER_ID"
319319
docker stop "$CONTAINER_ID"
320320
docker rm "$CONTAINER_ID"
321321
exit 1
322322
fi
323-
323+
324324
echo "Waiting for API... (attempt $i/30)"
325325
sleep 2
326326
done
327-
327+
328328
# Check container logs for errors
329329
docker logs "$CONTAINER_ID"
330-
330+
331331
# Stop the container
332332
docker stop "$CONTAINER_ID"
333333
docker rm "$CONTAINER_ID"
334-
334+
335335
echo "✅ Docker image tests passed"
336336
337337
dockerfile-check:
@@ -363,8 +363,8 @@ jobs:
363363
- name: Check Dockerfile is up to date
364364
run: |
365365
yarn update-dockerfile
366-
if ! git diff --quiet; then
366+
if ! git diff --quiet -- . ':!yarn.lock'; then
367367
echo "Dockerfile is not up to date. Please run 'yarn update-dockerfile' and commit the changes."
368-
git diff
368+
git diff -- . ':!yarn.lock'
369369
exit 1
370370
fi

0 commit comments

Comments
 (0)