From ddc04f5569f9e636d44faa502bc0af7b07e07116 Mon Sep 17 00:00:00 2001 From: Marguerite Blair Date: Mon, 16 Sep 2024 11:46:47 -0400 Subject: [PATCH] fix: add wallet type check for sign transaction Ticket: WP-2664 TICKET: WP-2664 --- modules/sdk-core/src/bitgo/wallet/wallet.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/modules/sdk-core/src/bitgo/wallet/wallet.ts b/modules/sdk-core/src/bitgo/wallet/wallet.ts index c07b329dba..c83b94b58f 100644 --- a/modules/sdk-core/src/bitgo/wallet/wallet.ts +++ b/modules/sdk-core/src/bitgo/wallet/wallet.ts @@ -1831,7 +1831,12 @@ export class Wallet implements IWallet { params.txPrebuild = { txRequestId }; } - if (params.walletPassphrase && !(params.keychain || params.key)) { + if ( + params.walletPassphrase && + !(params.keychain || params.key) && + (this.type() === 'hot' || this.type() === undefined) + ) { + // this logic should only apply to hot wallets if (!_.isString(params.walletPassphrase)) { throw new Error('walletPassphrase must be a string'); }