feat(express): lightning wallet creation step two #4783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
saravanan7mani
force-pushed
the
BTC-1356-lightning-wallet-step-2
branch
4 times, most recently
from
4774093
to
830612f
Compare
saravanan7mani
force-pushed
the
BTC-1356-lightning-wallet-step-2
branch
4 times, most recently
from
c43000b
to
7449cfd
Compare
lcovar
reviewed
Aug 12, 2024
modules/express/src/clientRoutes.ts
Outdated
|
|
||
| export function setupLightningRoutes(app: express.Application, config: Config): void { | ||
| app.post( | ||
| '/api/v2/:coin/initlightningwallet/:id', |
There was a problem hiding this comment.
:nit: personally think this is a bit cleaner of a route. On the handler we can check if it's a lightning coin, if it's not we can throw a not supported error.
Suggested change
| '/api/v2/:coin/initlightningwallet/:id', | |
| '/api/v2/:coin/:walletid/init', |
saravanan7mani
force-pushed
the
BTC-1356-lightning-wallet-step-2
branch
14 times, most recently
from
b3c95a2
to
dea64fa
Compare
saravanan7mani
force-pushed
the
BTC-1356-lightning-wallet-step-2
branch
from
dea64fa
to
4b769d3
Compare
saravanan7mani
force-pushed
the
BTC-1356-lightning-wallet-step-2
branch
3 times, most recently
from
f7527b3
to
93ad3ab
Compare
saravanan7mani
force-pushed
the
BTC-1356-lightning-wallet-step-2
branch
4 times, most recently
from
5bc7584
to
a5b1f23
Compare
initialize signer lnd and update platform. Ticket: BTC-1356
saravanan7mani
force-pushed
the
BTC-1356-lightning-wallet-step-2
branch
from
a5b1f23
to
07292a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initialize signer lnd and update platform.
Ticket: BTC-1356