Unify pricing information

[christroutner]

Here is the code controlling the price endpoint in BITBOX.

Seems Bitbox (and therefore Badger) are pulling from our price index at:
https://index-api.bitcoin.com/api/v0/cash/price/usd

While the new wallet is using the new markets API at,
https://markets.api.bitcoin.com/rates?c=BCH

causing slight price differences and confusion.

The scope of this issue is to:

1. Determine what the right source of pricing information is.
2. Implement that endpoint into the price endpoint for BITBOX.

What is the correct source of pricing information?

[BytesOfMan]

https://markets.api.bitcoin.com/live/bitcoin is used by the Bitcoin.com Universal Header.

Answering the original questions:

1. The right source of USD spot information is https://markets.api.bitcoin.com/live/bitcoin
2. This is what should be implemented in BITBOX

Additional background:

https://markets.api.bitcoin.com/rates?c=BCH is intended to be the correct source going forward, there is an open ticket to implement forex rates accessible by URLs (similar to index-api.bitcoin.com endpoint). So this URL and the data it accesses may change in the next couple of weeks.

If only USD rates are needed, this is a more manageable endpoint with the same (correct) information: https://markets.api.bitcoin.com/live/bitcoin

Unfortunately -- based on some quick testing, the two endpoints don't seem to update at exactly the same time.

[SpicyPete]

Hmm, forex rates are required to maintain current behavior.
Seems the rates? one may be the one needed, once it's stable.

[BytesOfMan]

This has been the issue preventing deprecation of index-api.bitcoin.com, since other tools also depend on its forex output.

[SpicyPete]

https://markets.api.bitcoin.com/rates/convertor?c=BCH
https://markets.api.bitcoin.com/rates/convertor?c=BCH&q=CHF

Forex endpoints seem to be live now