New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decodeOpReturn() reports invalid TX as valid #182

Open

christroutner opened this issue Apr 30, 2020 · 1 comment

Labels

bug

christroutner commented Apr 30, 2020

User @linkinpark9812 reports that bchjs.SLP.Utils.decodeOpReturn() reports an invalid transaction as valid:

Valid SLP send: https://explorer.bitcoin.com/bch/tx/a31c3167686f892d835727bc46b74bb11a46d74a8a6b08dc6cd82abb6e987b43

Invalid SLP send: https://explorer.bitcoin.com/bch/tx/a60a522cc11ad7011b74e57fbabbd99296e4b9346bcb175dcf84efb737030415

decodeOpReturn() reports the invalid SLP transaction as valid.

The text was updated successfully, but these errors were encountered:

christroutner added the bug label

Author

christroutner commented Apr 30, 2020

I need to fix this same bug in bch-js. I'll try to submit a PR to fix this when I fix it there.

My plan of attack is to replace the built-in OP_RETURN parsing with the slp-parse npm library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment