Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to install with Node js LTS (12.18.1) #185

Open
jeansouza opened this issue Jun 25, 2020 · 2 comments
Open

Not able to install with Node js LTS (12.18.1) #185

jeansouza opened this issue Jun 25, 2020 · 2 comments

Comments

@jeansouza
Copy link

I'm trying to install the lib in a project that uses the current Node js LTS version (12.18.1), but I'm having the following error:

make: *** [keccak.target.mk:129: Release/obj.target/keccak/src/addon.o] Error 1
make: Leaving directory '/node_modules/keccak/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/.nvm/versions/node/v12.18.1/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:194:23)
gyp ERR! stack     at ChildProcess.emit (events.js:315:20)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:275:12)
gyp ERR! System Linux 5.4.0-37-generic
gyp ERR! command "/.nvm/versions/node/v12.18.1/bin/node" "/.nvm/versions/node/v12.18.1/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /node_modules/keccak
gyp ERR! node -v v12.18.1
gyp ERR! node-gyp -v v5.1.0
gyp ERR! not ok 
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] rebuild: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] rebuild script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /.npm/_logs/2020-06-25T13_01_59_862Z-debug.log
Keccak bindings compilation fail. Pure JS implementation will be used.

Are there any plans to support the current LTS Node js version?

@christroutner
Copy link

christroutner commented Jun 25, 2020

I'm not sure what the plans are for BITBOX, but I maintain a fork of BITBOX called bch-js. It uses FullStack.cash instead of rest.bitcoin.com as a back end. I use it every day with Node.js v12 LTS.

@mariusk
Copy link

mariusk commented Jul 30, 2020

Same with Node v12.18.3 on a Mac.

The exact errors I'm getting are from building keccak (four similar in total, different places in the source though):

../src/addon.cc:37:47: error: too few arguments to function call, single argument 'context' was not specified
    unsigned int rate = info[0]->IntegerValue();

and this one:

../src/addon.cc:75:73: error: no matching member function for call to 'ToObject'
    KeccakWrapper* to = Nan::ObjectWrap::Unwrap<KeccakWrapper>(info[0]->ToObject());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants