Add check if all blueprint ports are connected #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
td5r
reviewed
Oct 17, 2019
| @@ -132,6 +132,7 @@ func Test_CtrlIterate__SimpleAggregation(t *testing.T) { | |||
| // Connect | |||
| require.NoError(t, ao.Delegate("iterator").Out().Connect(fo.Main().In())) | |||
| require.NoError(t, fo.Main().Out().Connect(ao.Delegate("iterator").In())) | |||
| require.NoError(t, ao.Main().Out().FullyConnected()) | |||
There was a problem hiding this comment.
memo to @td5r: control_iterate out port pushes data but 'port.FullyConnected' returns an error, which indicates, that out port is not connected ... why?!
kairichard
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
Unconnected outports of blueprints lead to two undesired effects:
pullon the port it will block all other data flowing forward on that portSolution
Before the blueprint is started check if all outports are connected. Easier said than done.
For the edge case, that operator running is for actually that one -> https://bitspark.de/slang/docs/operator/iterate with a connected delegate, the ports appear to be not connected because of
srcbeing empty. But it still works.Todo
src@td5r Ideas on how this can be done in a more robust way?