Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PySide2 due to building errors and replacement by PySide6 #4427

Open
2 tasks done
D3vil0p3r opened this issue Dec 6, 2024 · 0 comments
Open
2 tasks done

Drop PySide2 due to building errors and replacement by PySide6 #4427

D3vil0p3r opened this issue Dec 6, 2024 · 0 comments
Labels
type::bug Valid bug

Comments

@D3vil0p3r
Copy link
Contributor

D3vil0p3r commented Dec 6, 2024

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended

Bug description

Currently the building of PySide2 produces several errors:

In file included from /src/packages/pentesting/pyside2/src/build/sources/pyside2/PySide2/QtGui/PySide2/QtGui/qdragmoveevent_wrapper.cpp:63:
/src/packages/pentesting/pyside2/src/build/sources/pyside2/PySide2/QtGui/PySide2/QtGui/qdragmoveevent_wrapper.h:55:235: error: ‘DragMove’ is not a member of ‘QOpenGLShader’
   55 |     QDragMoveEventWrapper(const QPoint & pos, QFlags<Qt::DropAction> actions, const QMimeData * data, QFlags<Qt::MouseButton> buttons, QFlags<Qt::KeyboardModifier> modifiers, QFlags<QOpenGLShader::ShaderTypeBit> type = QOpenGLShader::DragMove);
      |                                                                                                                                                                                                                                           ^~~~~~~~
/src/packages/pentesting/pyside2/src/build/sources/pyside2/PySide2/QtGui/PySide2/QtGui/qdragmoveevent_wrapper.cpp: In constructor ‘QDragMoveEventWrapper::QDragMoveEventWrapper(const QPoint&, QFlags<Qt::DropAction>, const QMimeData*, QFlags<Qt::MouseButton>, QFlags<Qt::KeyboardModifier>, QFlags<QOpenGLShader::ShaderTypeBit>)’:
/src/packages/pentesting/pyside2/src/build/sources/pyside2/PySide2/QtGui/PySide2/QtGui/qdragmoveevent_wrapper.cpp:103:295: error: invalid user-defined conversion from ‘QFlags<QOpenGLShader::ShaderTypeBit>’ to ‘QEvent::Type’ [-fpermissive]
  103 | QDragMoveEventWrapper::QDragMoveEventWrapper(const QPoint & pos, QFlags<Qt::DropAction> actions, const QMimeData * data, QFlags<Qt::MouseButton> buttons, QFlags<Qt::KeyboardModifier> modifiers, QFlags<QOpenGLShader::ShaderTypeBit> type) : QDragMoveEvent(pos, actions, data, buttons, modifiers, type)
      |                                                                                                                                                                                                                                                                                                       ^~~~
In file included from /usr/include/qt/QtCore/qglobal.h:1307,
                 from /usr/include/qt/QtCore/qalgorithms.h:43,
                 from /usr/include/qt/QtCore/qdebug.h:44,
                 from /usr/include/qt/QtCore/QDebug:1,
                 from /src/packages/pentesting/pyside2/src/build/sources/pyside2/PySide2/QtGui/PySide2/QtGui/qdragmoveevent_wrapper.cpp:48:
/usr/include/qt/QtCore/qflags.h:138:29: note: candidate is: ‘constexpr QFlags<T>::operator Int() const [with Enum = QOpenGLShader::ShaderTypeBit; Int = unsigned int]’ (near match)
  138 |     Q_DECL_CONSTEXPR inline operator Int() const noexcept { return i; }
      |                             ^~~~~~~~
/usr/include/qt/QtCore/qflags.h:138:29: note:   no known conversion from ‘QFlags<QOpenGLShader::ShaderTypeBit>::Int’ {aka ‘unsigned int’} to ‘QEvent::Type’
In file included from /usr/include/qt/QtGui/qtextlayout.h:49,
                 from /usr/include/qt/QtGui/qtextobject.h:46,
                 from /usr/include/qt/QtGui/QTextBlock:1,
                 from /src/packages/pentesting/pyside2/src/build/sources/pyside2/PySide2/QtGui/PySide2/QtGui/pyside2_qtgui_python.h:60,
                 from /src/packages/pentesting/pyside2/src/build/sources/pyside2/PySide2/QtGui/PySide2/QtGui/qdragmoveevent_wrapper.cpp:60:
/usr/include/qt/QtGui/qevent.h:685:84: note:   initializing argument 6 of ‘QDragMoveEvent::QDragMoveEvent(const QPoint&, Qt::DropActions, const QMimeData*, Qt::MouseButtons, Qt::KeyboardModifiers, QEvent::Type)’
  685 |                    Qt::MouseButtons buttons, Qt::KeyboardModifiers modifiers, Type type = DragMove);
      |                                                                               ~~~~~^~~~~~~~~~~~~~~
/src/packages/pentesting/pyside2/src/build/sources/pyside2/PySide2/QtGui/PySide2/QtGui/qdragmoveevent_wrapper.cpp: In function ‘int Sbk_QDragMoveEvent_Init(PyObject*, PyObject*, PyObject*)’:
/src/packages/pentesting/pyside2/src/build/sources/pyside2/PySide2/QtGui/PySide2/QtGui/qdragmoveevent_wrapper.cpp:218:73: error: ‘DragMove’ is not a member of ‘QOpenGLShader’
  218 |         ::QFlags<QOpenGLShader::ShaderTypeBit> cppArg5 = QOpenGLShader::DragMove;
      |                                                                         ^~~~~~~~
make[2]: *** [sources/pyside2/PySide2/QtGui/CMakeFiles/QtGui.dir/build.make:559: sources/pyside2/PySide2/QtGui/CMakeFiles/QtGui.dir/PySide2/QtGui/qdragmoveevent_wrapper.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2000: sources/pyside2/PySide2/QtGui/CMakeFiles/QtGui.dir/all] Error 2

See https://forum.qt.io/topic/144731/pyside2-missing-qopenglshader

Currently PySide2 is used by:

  • angr-management
  • binaryninja-python
  • rfcat

I would suggest to push upstream and update the related packages in order to use PySide6.

@D3vil0p3r D3vil0p3r added the type::bug Valid bug label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::bug Valid bug
Projects
None yet
Development

No branches or pull requests

1 participant