-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Random ringtone playing #126
base: main
Are you sure you want to change the base?
Conversation
I'll take a look soon. |
Sorry about that, I'm still using an old version of android studio, which doesn't support the current one. |
I suspected as much; don't worry, if necessary, I'll do it myself. |
@Nilsu11 Can you tell me if the ringtone random playback also takes into account ringtones added by the user? |
Currently not. Only the defauly system ringtones |
@Nilsu11 Finally, I cannot make any changes to your PR certainly because your "main" branch is protected. |
-the ability to "silance after" ALL random alarms
@BlackyHawky This change should fix the issue, but it is still untested. the thing with random alarms, sadly, is, that I can't predict the ringtone without providing a seed (which I don't want to generate), so I currently only can offer this solution |
@Nilsu11 |
@Nilsu11 I've also tried it with custom ringtones and the problem is the same. |
sorry for the very late reply :( , I finally found time to look at this issue again and found a mayor oversight on my part. I am now trying to fix this now somehow. @BlackyHawky do you know somebody with few (something like 3) alarm ringtones on their phone to check if it works? |
@Nilsu11 I'll be testing your changes very soon. |
This pull request should resolve #98