Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Refactor Notification System #474

Open
zimjjan opened this issue Mar 19, 2023 · 10 comments
Open

Feature Request: Refactor Notification System #474

zimjjan opened this issue Mar 19, 2023 · 10 comments
Labels
Enhancement For suggestions that add new features or improve existing functionalities.

Comments

@zimjjan
Copy link

zimjjan commented Mar 19, 2023

It would be awesome to have a more sophisticated notification system:

  • timestamp of notification
  • multiple notifications
  • home assistant events for confirm/decline (maybe also provide a context value in the service to correlate notification and event)
@Blackymas Blackymas added the Enhancement For suggestions that add new features or improve existing functionalities. label Mar 19, 2023
@Blackymas
Copy link
Owner

we will see what else is possible :)

@Floppe
Copy link
Contributor

Floppe commented Mar 21, 2023

Perhaps options

  • whether to make noise or not (quite mode)
  • song type
  • auto dismiss after a timeout or needed confirmation

Sometimes it would be great to only flash a notification as information only that auto dismiss itself. No need for sound. Other times perhaps an alert that need immediate attention, so make noise and require confirmation.

@edwardtfn
Copy link
Collaborator

home assistant events for confirm/decline (maybe also provide a context value in the service to correlate notification and event)

Coud you please elaborate more? You want to trigger an event on HA when a notification is confirmed/declined? or do you want to see as a notification in Home Assistant?

@edwardtfn
Copy link
Collaborator

edwardtfn commented Aug 25, 2023

Sometimes it would be great to only flash a notification as information only that auto dismiss itself. No need for sound. Other times perhaps an alert that need immediate attention, so make noise and require confirmation.

You mean like having different levels of notification (info/alert/urgent) and a different behaviour (sound, icon, color, etc) for each level?

@edwardtfn
Copy link
Collaborator

The biggest challenge is on the difficulties for storing text by a blueprint or by ESPHome, so will you all be fine if the notifications disappears when ESPHome restarts (just like it is with the current implementation)?

@edwardtfn
Copy link
Collaborator

I have another question for you about current implementation of notifications while I'm thinking about this refactoring...
There are a few sensors and switches visible on Home Assistant:

  1. Switch - Confirmation message (not directly related to Notifications, but send a info to decide what show on notification screen)
  2. Switch - Notification unread
  3. Sensor - Notification label
  4. Sensor - Notification text

Is there a need to have those values in Home Assistant for other than managing the behaviour of the blueprint? Or are you using those values outside the blueprint?

@CDuy
Copy link

CDuy commented Sep 30, 2023

As far as notifications go, it might be useful to have a "snooze" button on the popup, which doesn't dismiss the notification icon from the main screen. Maybe it'd snooze the notification for X amount of time until it pops up again?

@edwardtfn
Copy link
Collaborator

What about a "to do" replacing notifications?

#1129

@zimjjan
Copy link
Author

zimjjan commented Nov 26, 2023

I'll give you an exapmle for that one:
Imagine a notification that says "Someones at the door, open?" which you then could either accept or decline.

To implement this behavior, I need ...

  • a way of distinguishing what exact notification was shown,
  • the info, whether the notifcation was accepted or declined.

The cherry on top would be, to have the option to have multiple "active" notifications at once, to also implement things, that do not need "immediate" feedback. Example: "There is new mail in the mailbox." --> when accepted, delete the new mailbox indicator, that also influences e.g. a status light.
Example 2: "Window XY has been open for more then Z minutes" --> There are multiple windows so multiple notifications would be good (as a list).

@zimjjan
Copy link
Author

zimjjan commented Dec 4, 2023

Looking into the todo entity, this could actually be the solution. A single todo entity, which manages the items that than are shown as notifications and also can be shown an interactable list.

@edwardtfn edwardtfn removed the Roadmap label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For suggestions that add new features or improve existing functionalities.
Projects
None yet
Development

No branches or pull requests

5 participants