Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Search type: Hash #309

Open
EveKaczmarek opened this issue Jul 6, 2024 · 2 comments
Open

[Feature]: Search type: Hash #309

EveKaczmarek opened this issue Jul 6, 2024 · 2 comments
Labels
bug Something isn't working WIP Being worked on

Comments

@EveKaczmarek
Copy link

Describe the bug.

Hi,

First, I want to say that I love your extension and greatly appreciate your commitment to supporting and developing it further.

I have a suggestion for a quality of life feature that I believe would be quite useful. Civitai allows users to find models by entering a hash in the search bar, which is tremendously helpful if the model metadata is lost or if the model hash is extracted from the image metadata.

Therefore, my suggestion is to add similar functionality to Civitai Browser+. This would enable users to perform a hash search by marking the search type as "hash" in the filter menu.

If this is possible, it would be a fantastic addition.

I apologize for opening this issue as a bug report rather than a discussion topic. The discussions section seems to be rather inactive.

Steps to reproduce the problem.

  1. Open any image generated in the WebUI in the PNG Info tab
  2. Copy a model hash (for instance ac006fdd7e)
  3. Paste in the Civitai Browser+ search bar and click on the Search
  4. ???
  5. See nothing

Expected behavior

The extension should perform a hash search and return a model card.

System info

  • Extension version: v3.5.4
  • OS: Windows 10
  • SD-WebUI version: Forge
  • Python: 3.10

Console logs

N/A

Additional information

No response

@EveKaczmarek EveKaczmarek added the bug Something isn't working label Jul 6, 2024
@Lumerica
Copy link

In Addition to search, a more pressing thing. I also noticed that the Update option also often cannot find the model on civitai whilst you are sure it is there.
And often times it happens if you renamed the model.
So I think that the Update model should use the hash to check on civitai to see whether that is the model or not.

@BlafKing
Copy link
Owner

Sounds good! I'll look into adding more search types, including hash.

In Addition to search, a more pressing thing. I also noticed that the Update option also often cannot find the model on civitai whilst you are sure it is there. And often times it happens if you renamed the model. So I think that the Update model should use the hash to check on civitai to see whether that is the model or not.

The extension attempts to find models by looking for a matching filename and by looking through the associated .json file, which should contain the hash if downloaded through the extension, or if the One-Time Hash Generation has been run.

When you rename a model, you need to make sure to also rename it's associated .json file, otherwise it will indeed fail to find the model.

@BlafKing BlafKing added the WIP Being worked on label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working WIP Being worked on
Projects
None yet
Development

No branches or pull requests

3 participants