-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove scipy dependency #253
Comments
I agree with you! Could you send a PR and add some metrics like performance (acc and performance)? |
Also scipy is pinned in the requirements, which makes it harder to install mlx-vlm in an environment with other packages. |
on it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Its a heavy dependency which requires external libraries and tooling installed.
We are only using it for the scipy.ndimage.zoom method which is provided both by Pillow and OpenCV which are already a depepndency for this project.
Of the top of my head these two implementations can replace zoom method, note that the opencv one will be the best performant:
or
The text was updated successfully, but these errors were encountered: