Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix countSetBits function #270

Closed
MahendraTennakoon opened this issue Oct 21, 2017 · 2 comments
Closed

Fix countSetBits function #270

MahendraTennakoon opened this issue Oct 21, 2017 · 2 comments

Comments

@MahendraTennakoon
Copy link
Contributor

There is currently a method called countSetBits that lives in /lib/countSetBits .js.
It is incomplete and needs to be fixed!

Acceptance Criteria:

  1. Running yarn test <methodName> results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

@MahendraTennakoon MahendraTennakoon changed the title Fix countSetBits method Fix countSetBits function Oct 21, 2017
@BlakeGuilloud
Copy link
Owner

Hey @MahendraTennakoon this method has already been resolved. Perhaps you have an older version of the project? Make sure to pull from the upstream master.

@BlakeGuilloud
Copy link
Owner

The PR that resolved this: #204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants