Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix promisify function #718

Open
kylevv opened this issue Oct 31, 2017 · 4 comments
Open

Fix promisify function #718

kylevv opened this issue Oct 31, 2017 · 4 comments

Comments

@kylevv
Copy link
Contributor

kylevv commented Oct 31, 2017

There is currently a method called promisify that lives in /lib/promisify.js.
It is incomplete and needs to be fixed!

Promisify takes an asynchronous function that uses node style callbacks and returns a function that will return a promise instead.

Acceptance Criteria:

  1. Running yarn test promisify results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

@kylevv
Copy link
Contributor Author

kylevv commented Oct 31, 2017

Requires #717 to be merged first.

@BlakeGuilloud
Copy link
Owner

Can't believe no one has taken this yet!

@arturoromeroslc
Copy link

I can take a stab at it.

@ktilcu
Copy link
Collaborator

ktilcu commented Jan 4, 2018

@arturoromeroslc Have fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants