Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface area of Frustum #775

Open
jsjain opened this issue Nov 19, 2017 · 0 comments
Open

Surface area of Frustum #775

jsjain opened this issue Nov 19, 2017 · 0 comments

Comments

@jsjain
Copy link
Contributor

jsjain commented Nov 19, 2017

There is currently a method called surfaceAreaOfFrustum that lives in /lib/surfaceAreaOfFrustum.js.
It is incomplete and needs to be fixed!

It expects 3 args smaller radius r1, bigger radius r2 and height h with a fourth optional parameters to return Total surface area or Lateral Surface Area.
By default method will return Total Surface Area .

Acceptance Criteria:

  1. Running yarn test surfaceAreaOfFrustum results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

jsjain added a commit to jsjain/ganon that referenced this issue Nov 19, 2017
BlakeGuilloud pushed a commit that referenced this issue Nov 19, 2017
* improved isPrime implementation to make it even faster

* fixes #759

* template for issue #775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants