Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Statistical Outliers #787

Open
crhallberg opened this issue Oct 3, 2018 · 3 comments
Open

Remove Statistical Outliers #787

crhallberg opened this issue Oct 3, 2018 · 3 comments

Comments

@crhallberg
Copy link
Contributor

As of #785, there is currently a method called removeOutliers that lives in /lib/removeOutliers.js.
It is incomplete and needs to be fixed!

Using mean and standard deviations, this function filters out numbers that are more than a specified number of standard deviations away from the mean (default 1).

Acceptance Criteria:

  1. Running yarn test <methodName> results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

@anurag-rai
Copy link

Hi, I'd like to work on this. I'm new here so having a difficulty understanding how creating another skeleton works.

@crhallberg
Copy link
Contributor Author

Hello! There are full instructions in the contributing guide. Essentially, you complete my skeleton and then you make a challenge for the next person. This involves:

  1. Making a new file in lib/ with a function
  2. Writing a test that enforces the expected outcomes of your new function.

Once you make a pull request for completing this function, I'll be happy to help with this next part.

@anurag-rai
Copy link

Aweomse. I'm already working on this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants