Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getArrayElementCount method #768

Open
jsjain opened this issue Nov 5, 2017 · 1 comment · May be fixed by #810
Open

Fix getArrayElementCount method #768

jsjain opened this issue Nov 5, 2017 · 1 comment · May be fixed by #810

Comments

@jsjain
Copy link
Contributor

jsjain commented Nov 5, 2017

There is currently a method called getArrayElementCount that lives in /lib/getArrayElementCount.js.
It is incomplete and needs to be fixed!

First argument should be array and second arg can be a number or an array.
If first arg is number it returns the number of occurrences of that number.
If second arg is array it returns the combined sum of number of occurrences of elements in array.

For eg: in arrray = [1,2,3,4,5] if [1,2] is given as second arg it should return 2 as 1 occurs once and so does 2 therefore total of 2.

Acceptance Criteria:

  1. Running yarn test <methodName> results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

jsjain added a commit to jsjain/ganon that referenced this issue Nov 5, 2017
@jsjain
Copy link
Contributor Author

jsjain commented Nov 5, 2017

Assuming PR #769 gets merged.

BlakeGuilloud pushed a commit that referenced this issue Nov 6, 2017
* fixes #621

* for issue #651

* fixes #767

* for issue #768
@jacksjm jacksjm linked a pull request Oct 15, 2021 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants