Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlimited remnant pickups exploit #45

Open
l29ah opened this issue Sep 24, 2018 · 1 comment · May be fixed by #57
Open

Unlimited remnant pickups exploit #45

l29ah opened this issue Sep 24, 2018 · 1 comment · May be fixed by #57

Comments

@l29ah
Copy link
Contributor

l29ah commented Sep 24, 2018

https://steamcommunity.com/app/282590/discussions/0/1290691937710672216/
Reproduced it on ba99a9a
I've took a look on the corresponding .as files that govern pickup mechanics, but they all look innocent. Maybe there's some resource locking at play?

@Lucas7211
Copy link
Member

The way pickups were coded is that they destroy themselves when they get picked up, but destroy isn't an instant operation, it will take at the very least one tick to finish destroying itself (and even after that the object will linger until it can be garbage collected usually).

So if you queue multiple orders on the pickup they will all trigger on the pickup before it gets destroyed, triggering the effect multiple times.

Best solution would be for the pickup to track whether it has already been picked up internally and just early-out if it's attempted multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants