Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE REQUEST: Crypto-request for descriptors #171

Open
ChristopherA opened this issue May 7, 2022 · 1 comment
Open

FEATURE REQUEST: Crypto-request for descriptors #171

ChristopherA opened this issue May 7, 2022 · 1 comment
Labels
enhancement New feature or request stretch-goal Do last for this release, only if easy, otherwise move to backlog
Milestone

Comments

@ChristopherA
Copy link
Contributor

Looking forward at the whole cycle of what happens between a transaction coordinator and 3 signers, there is one last phase where the transaction coordinator, having all the xpubs, ought to have the option send the final descriptor to all the signers (if they want it).

Not sure if this should be a 1.5 thing or something we'll learn when doing the transaction coordinator. Some signers have no state (Passport) and will not want it. Others, like Gordian Seed Tool, may need it so that it can create a backup accounts associated with seeds, or initiate a policy where it won't sign any PSBTs for accounts that it didn't get registered.

I see the possible 1.5 feature just simply allowing basic crypto-request export and import of a descriptor, then puzzle out how/when it might work more fully in a flow in a subsequent releases after we learn from the transaction coordinator.

Definitely a stretch goal.

@ChristopherA ChristopherA added enhancement New feature or request stretch-goal Do last for this release, only if easy, otherwise move to backlog labels May 7, 2022
@ChristopherA ChristopherA added this to the Release 1.5 milestone May 7, 2022
@wolfmcnally wolfmcnally modified the milestones: Release 1.5, Backlog May 7, 2022
@ChristopherA
Copy link
Contributor Author

The more I think about it, it is more complex than I originally thought.

Basically, a signer that wants the final multisig descriptor back (like Gordian Seed Signer should, but stateless wallets like Passport will not), when it returns a successful crypto-response of crypto-hdkey, it should embed in it crypto-request to "please send descriptor back when it is completed by all the other signers".

I don't think we can put a crypto-request inside a crypto-response, so that makes this immediately not possible in 1.5, and thus backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stretch-goal Do last for this release, only if easy, otherwise move to backlog
Projects
None yet
Development

No branches or pull requests

2 participants