StreamPriceAccounts: fix goroutine leak (#5)

Richard Patel · web-flow · commit cb32dc93a0d6 · 2022-03-04T15:17:43.000+01:00
diff --git a/prices.go b/prices.go
@@ -43,7 +43,7 @@ func (c *Client) StreamPriceAccounts(ctx context.Context, updates chan<- PriceAc
 		default:
 			return err
 		}
-	}, backoff.NewConstantBackOff(retryInterval))
+	}, backoff.WithContext(backoff.NewConstantBackOff(retryInterval), ctx))
 }
 
 func (c *Client) streamPriceAccounts(ctx context.Context, updates chan<- PriceAccountUpdate) error {
@@ -53,6 +53,12 @@ func (c *Client) streamPriceAccounts(ctx context.Context, updates chan<- PriceAc
 	}
 	defer client.Close()
 
+	// Make sure client cannot outlive context.
+	go func() {
+		defer client.Close()
+		<-ctx.Done()
+	}()
+
 	metricsWsActiveConns.Inc()
 	defer metricsWsActiveConns.Dec()
 

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ func (c *Client) StreamPriceAccounts(ctx context.Context, updates chan<- PriceAc`
`43`	`43`	`default:`
`44`	`44`	`return err`
`45`	`45`	`}`
`46`		`- }, backoff.NewConstantBackOff(retryInterval))`
	`46`	`+ }, backoff.WithContext(backoff.NewConstantBackOff(retryInterval), ctx))`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`func (c *Client) streamPriceAccounts(ctx context.Context, updates chan<- PriceAccountUpdate) error {`
`@@ -53,6 +53,12 @@ func (c *Client) streamPriceAccounts(ctx context.Context, updates chan<- PriceAc`
`53`	`53`	`}`
`54`	`54`	`defer client.Close()`
`55`	`55`
	`56`	`+ // Make sure client cannot outlive context.`
	`57`	`+ go func() {`
	`58`	`+ defer client.Close()`
	`59`	`+ <-ctx.Done()`
	`60`	`+ }()`
	`61`	`+`
`56`	`62`	`metricsWsActiveConns.Inc()`
`57`	`63`	`defer metricsWsActiveConns.Dec()`
`58`	`64`