Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: [/compareCurrencies] messes up navigation history #1390

Closed
janat08 opened this issue May 1, 2018 · 8 comments
Closed

Problem: [/compareCurrencies] messes up navigation history #1390

janat08 opened this issue May 1, 2018 · 8 comments
Labels
low_priority Probably needs to be done sometime, but not a huge problem right now. unmet dependency This issue has an unmet dependency which should be completed first.

Comments

@janat08
Copy link
Collaborator

janat08 commented May 1, 2018

Problem: Using back and forth after using typeahead will break back and forth navigation.
@anbud
Copy link
Member

anbud commented May 1, 2018

I can't seem to replicate this one on production. What's exactly happening? Tried going back and forth, but it always landed on the page it's supposed to land.

@janat08
Copy link
Collaborator Author

janat08 commented May 1, 2018

Land on [/], go to auctions via link, go to compare currencies, press enter, try to go back.

@janat08
Copy link
Collaborator Author

janat08 commented May 1, 2018

Yes that works reliably. I tried this a bunch before it popped up again.

@janat08
Copy link
Collaborator Author

janat08 commented May 4, 2018

#1445 related.

@janat08
Copy link
Collaborator Author

janat08 commented May 4, 2018

it's likely not related, since while it will still look a navigation history even with every possible routing module removed, in addCoin the external button was used and so it didn't initialize properly.

@janat08
Copy link
Collaborator Author

janat08 commented May 4, 2018

nx-js/framework#25
I'd try commenting out nx-framework component, and not importing the library to see if behaviour is fixed.

@janat08
Copy link
Collaborator Author

janat08 commented May 4, 2018

nx is the culprit.

@janat08
Copy link
Collaborator Author

janat08 commented May 4, 2018

@blockrazorbot label "low_priority" "unmet dependency"

@blockrazorbot blockrazorbot added low_priority Probably needs to be done sometime, but not a huge problem right now. unmet dependency This issue has an unmet dependency which should be completed first. labels May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low_priority Probably needs to be done sometime, but not a huge problem right now. unmet dependency This issue has an unmet dependency which should be completed first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@anbud @gsovereignty @janat08 @blockrazorbot