Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][fabric] support {{@mcversion@}} and {{@loaderversion@}} in installerArguments and add installerVersion #69

Open
FederAndInk opened this issue Jul 26, 2022 · 0 comments

Comments

@FederAndInk
Copy link

the fabric installer needs to be called with minecraft and loader version, it could be great to inject those variable in the installerArguments:

  installerArguments:
    - "server"
    - "-downloadMinecraft"
    - "-mcversion"
    - "{{@mcversion@}}"
    - "-loader"
    - "{{@loaderversion@}}"

Also this doesn't work, as the loaderVersion is not the same as the installer version for fabric:

# For Fabric: "https://maven.fabricmc.net/net/fabricmc/fabric-installer/{{@loaderversion@}}/fabric-installer-{{@loaderversion@}}.jar"

For instance the fabric installer: https://maven.fabricmc.net/net/fabricmc/fabric-installer/0.11.0/fabric-installer-0.11.0.jar
and it could be called like this: java -jar fabric-installer-0.11.0.jar server -downloadMinecraft -mcversion 1.18.2 -loader 0.14.8

So it could be great to also add installerVersion to be able to do:

  installerUrl: "https://maven.fabricmc.net/net/fabricmc/fabric-installer/{{@installerversion@}}/fabric-installer-{{@installerversion@}}.jar"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant