Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional for checking offline status is flipped #75

Open
trunksbomb opened this issue Apr 2, 2024 · 0 comments
Open

Conditional for checking offline status is flipped #75

trunksbomb opened this issue Apr 2, 2024 · 0 comments

Comments

@trunksbomb
Copy link

if (!internetManager.checkConnection() && config.launch.checkOffline) {
LOGGER.error("Problems with the Internet connection, please check your connection!\n" +
"This could however be a problem with the servers as well.\n" +
"Continuing to download, but this may fail!")
}

First it checks the internet connection, then it checks if it even matters if there is one.

It should just skip checking for an internet connection if the config checkOffline is false. Changing the order of the two conditionals in that if statement will resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant