Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c-blosc needs a CMake package file #319

Open
bnavigator opened this issue Aug 5, 2021 · 3 comments
Open

c-blosc needs a CMake package file #319

bnavigator opened this issue Aug 5, 2021 · 3 comments

Comments

@bnavigator
Copy link

@thewtex suggests to create a CMake package file instead of this PRs FindBlosc.cmake

Yes, we should definitely be using a CMake package configuration file instead of a Find module. But, if @bnavigator is not willing to make those changes, this is still a step forward. We could merge this and make additional progress later.

Originally posted by @thewtex in Blosc/python-blosc#244 (comment)

@bnavigator bnavigator changed the title c-blosc needs a CMAKE package file c-blosc needs a CMake package file Aug 5, 2021
@mgorny
Copy link
Contributor

mgorny commented Oct 7, 2021

Gentle ping. Apparently python-blosc already requires this file even though FWICS nobody wrote it x_x.

@bnavigator
Copy link
Author

python-blosc does not require this file. It provides it's own FindBlosc.cmake because the CMake package file does not exist yet.

@imikejackson
Copy link

Gentle ping on this? Or maybe I'm just not trying to include C-Blosc in the correct way in my project? Should I just use a git-submodule instead and build blosc as part of my project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants