Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Enable multi-threading tests (MPI+OpenMP) under CI #292

Open
pramodk opened this issue Apr 20, 2020 · 3 comments · May be fixed by #299
Open

Enable multi-threading tests (MPI+OpenMP) under CI #292

pramodk opened this issue Apr 20, 2020 · 3 comments · May be fixed by #299
Assignees
@iomaganaris
Projects
CoreNEURON Development
Milestone
NEURON v8.0 Release

Comments

@pramodk
Copy link
Collaborator

pramodk commented Apr 20, 2020

I think we are currently we running pure MPI tests under CI. We should run MPI+OpenMP tests to catch any threading errors.
@pramodk pramodk mentioned this issue Apr 20, 2020
Merged
11 tasks
@iomaganaris
Copy link
Contributor

In the CI we build CoreNeuron SoA with OpenMP enabled

CoreNeuron/tests/jenkins/install_coreneuron.sh

Line 57 in 76026e0

ENABLE_OPENMP=ON
and we run the SoA tests with

CoreNeuron/tests/jenkins/run_corenrn.sh

Line 17 in 76026e0

export OMP_NUM_THREADS=2
. I see though that for some reason when CoreNeuron runs it prints num_omp_thread=1 even if the OMP_NUM_THREADS is set to 2. Maybe that's because we don't run it with --threading? I need to investigate

@iomaganaris iomaganaris self-assigned this Apr 21, 2020
@iomaganaris iomaganaris mentioned this issue Apr 21, 2020
Merged
@pramodk
Copy link
Collaborator Author

pramodk commented Apr 21, 2020 •
edited
Loading

@iomaganaris : IMO we need a test with more concurrency (more than ring). e.g. If we are using 36 cores on Jenkis CI, using 6 MPI ranks each with 6 threads. This can help to detect race condition bit. We can discuss this what should/can do.

@iomaganaris iomaganaris linked a pull request Apr 29, 2020 that will close this issue
Draft
@pramodk pramodk added this to the NEURON release 8.0 milestone Jul 24, 2020
@pramodk pramodk moved this from Todo to In Progress in CoreNEURON Development Jul 24, 2020
@olupton olupton mentioned this issue Jun 30, 2021
Open
@pramodk pramodk mentioned this issue Oct 29, 2021
Merged
@olupton
Copy link
Contributor

olupton commented Aug 25, 2022

We have CI builds that enable OpenMP (host) threading:

CoreNeuron/.gitlab-ci.yml

Line 89 in d6507e2

SPACK_PACKAGE_SPEC: +gpu+openmp+tests~legacy-unit build_type=RelWithDebInfo
and tests that use multiple threads https://github.com/neuronsimulator/nrn/blob/1b76917231a00281e17bac760d013f9a5c13cd95/test/external/ringtest/CMakeLists.txt#L90-L100, but I'm not sure if this is enough.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@iomaganaris iomaganaris

Labels
None yet
Projects
CoreNEURON Development
  
In Progress
Milestone
NEURON v8.0 Release
Development

Successfully merging a pull request may close this issue.

Added hybrid MPI+OpenMP test in CI BlueBrain/CoreNeuron
3 participants
@pramodk @olupton @iomaganaris