Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in missing parent exception between readonly and mut #200

Open
eleftherioszisis opened this issue Oct 28, 2020 · 3 comments
Open
Assignees

Comments

@eleftherioszisis
Copy link
Collaborator

import morphio
m = morphio.Morphology(filename).root_sections[0].parent

raises:

MissingParentError: Cannot call Section::parent() on a root node (section id=0).

while:

import morphio
m = morphio.mut.Morphology(filename).root_sections[0].parent

raises:

IndexError: map::at

It is important for readonly and mut to exhibit similar behaviour so that they can be used by algorithms interchangeably.

@asanin-epfl asanin-epfl assigned tomdele and unassigned wizmer May 21, 2021
@asanin-epfl
Copy link
Contributor

Tom, please look if you have a moment.

@tomdele
Copy link
Contributor

tomdele commented May 25, 2021

Yeah I will try to check that

@tomdele tomdele assigned eleftherioszisis and unassigned tomdele Jun 30, 2021
@tomdele
Copy link
Contributor

tomdele commented Jun 30, 2021

Elef you are the king of this ticket now congratz ! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants