Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should MorphIO warn when child's first point does not equal parent's last point? #287

Open
asanin-epfl opened this issue Apr 16, 2021 · 0 comments

Comments

@asanin-epfl
Copy link
Contributor

asanin-epfl commented Apr 16, 2021

When sanitize/removeUnifurcations was disabled on morphology reading, some checks besides unifurcation were disabled as well. It happened because WARNING_WRONG_DUPLICATE happened on sanitize and it checked for multiple edge cases.

For example, this file does not give any warning now, however the child does not continue the parent.

    with tmp_asc_file('''
                     ((Dendrite)
                      (3 -4 0 5)
                      (3 -10 0 5)
                      (
                        (5 -10 0 10)
                        (0 -10 0 2)
                      )
                      )
                     ''') as tmp_file:
        Morphology(tmp_file.name)

This file does not trigger any warning as well, however axon root points do not equal their parent soma points.

1 1 1 0 1 4.0 -1
2 1 2 0 0 4.0 1
3 1 3 0 0 4.0 2
4 2 4 4 4 4    1  # branch from 'start' of soma
5 2 5 5 5 5    2  # branch from 'middle' of soma
6 2 6 6 6 6    3  # branch from 'end' of soma

cc @tomdele

@asanin-epfl asanin-epfl self-assigned this Apr 16, 2021
@asanin-epfl asanin-epfl changed the title SWC sections are ignored if they attached not to the first soma section. SWC sections with one point are ignored. Apr 28, 2021
@asanin-epfl asanin-epfl changed the title SWC sections with one point are ignored. split WARNING_WRONG_DUPLICATE on its constituent parts. Apr 28, 2021
@asanin-epfl asanin-epfl changed the title split WARNING_WRONG_DUPLICATE on its constituent parts. Should MorphIO warn when child's first point does not equal parent's last point? Apr 28, 2021
@asanin-epfl asanin-epfl removed their assignment Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant